ErrorAccumulatingUnmarshaller from akka-http-json lib no longer applying validations in 0.9.2
See original GitHub issueWe have some Decoders with attached validations like this:
implicit val decodeSomething = deriveDecoder[Something].validate(..., ...)
And we use this for our akka-http routes (https://github.com/hseeberger/akka-http-json):
trait AkkaHttpCirceSupport extends BaseCirceSupport with ErrorAccumulatingUnmarshaller
And after updating to 0.9.2 that validation is no longer applied.
Switching to FailFastCirceSupport
makes the validation run again. It’s probably related to https://github.com/circe/circe/pull/838/files, but I’m not sure.
Reverting to 0.9.1
makes ErrorAccumulatingUnmarshaller
run validations again.
I put together a couple of tests showing this here: https://github.com/yurique/akka-http-json-fail/tree/validation-fail (validation-fail branch)
sbt test
fails in one of the cases; changing circe to v0.9.1
makes them pass.
I’m not sure if this is related to circe or to akka-http-json
lib.
/cc @hseeberger
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Submission Validation Service for single project and multi ...
10/22/2019 • ERA Analyst (RH) Rule (005.21.11) which was added for validating and enforcing ORCID id requirements for application for individual ...
Read more >Cerberus Changelog
Fix: when 'items' is applied to a list, field name is used as key for 'validator.errors', and offending field indexes are used as...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Confirmed—this slipped by in #838. Publishing a fix this afternoon.
Thank you!