question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Disallow obsolete attributes/values

See original GitHub issue

Since CSL 1.0, the schema has been rewritten to include separate definitions for dependent and independent styles. As a result, we can be more specific with regard to the attributes and attributes values allowed for each type. We should probably make this change in CSL 1.1 to prevent style from becoming invalid. The attributes/values affected:

  • for cs:link, “independent-parent” (independent styles) and “template” (dependent styles)
  • for cs:style, “class”, and any of the style options (dependent styles)

These can all just be stripped from styles with the next XSLT upgrade script, and removed from the schema.

Issue Analytics

  • State:closed
  • Created 12 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
bdarcuscommented, Jun 5, 2020

And I just added a commit with the XSLT file. It currently only strips link elements with those two values, and updates the version number.

As you can see, it’s trivial.

https://github.com/citation-style-language/schema/blob/v1.1/tools/csl-update.xsl

1reaction
rmzellecommented, Jun 4, 2020

And in the past the CSL project provided a XSLT schema to upgrade 0.8.1 styles to 1.0 (https://docs.citationstyles.org/en/1.0/release-notes.html#updating-csl-0-8-styles). I don’t know if we should offer that for 1.1 as well? …

We could; sure.

Maybe we can tag PRs that involve changes where styles/locales can/should be upgraded as such with a GitHub label? (just dropping attributes would be easy to do in XSLT)

(that might be handier than having to update an XSLT for each relevant PR that is merged)

Read more comments on GitHub >

github_iconTop Results From Across the Web

c# - When should I use the [Obsolete] attribute and when ...
The Obsolete attribute marks a program entity as one that is no longer recommended for use. Each use of an entity marked obsolete...
Read more >
ObsoleteAttribute Class (System) - Microsoft Learn
ObsoleteAttribute is applicable to all program elements except assemblies, modules, parameters, and return values. Marking an element as obsolete informs users ...
Read more >
Allow Obsolete attribute on getters and setters #32472 - GitHub
The attribute Obsolete is used to mark types and members of types that should no longer be used. using System; [AttributeUsage(AttributeTargets.
Read more >
How to make a method deprecated in C#? - Tutorialspoint
The Obsolete Attribute marks elements like classes, methods, properties, fields, delegates, and many others within our code as deprecated or ...
Read more >
11 Obsolete features — HTML5 - W3C
The attribute should be entirely omitted instead (with the value " JavaScript ", it has no effect), or replaced with use of the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found