Change/expose Harmony ID
See original GitHub issuesee https://github.com/CitiesSkylinesMods/TMPE/pull/866#discussion_r427456974
Other mods can use Harmony ID to control priorities using [HarmonyBefore()]
and [HarmonyAfter()]
attributes see https://harmony.pardeike.net/articles/priorities.html
Attributes require compile time constants so we cannot evaluate the string runtime.
Argument could be made that the harmony string should be in TMPE.API although I believe tits better that other mods just copy paste the string.
For the sake of backward compatibility the value of Harmony ID should not change.
The harmony ID currently is de.viathinksoft.tmpe
.
Since according to this github search the only mod that is using harmony id is my node controller. it should not cause too much trouble to change this one last time. I can modify my code to include both IDs 😃 .
[HarmonyBefore("de.viathinksoft.tmpe")]
[HarmonyBefore("new harmony ID")]
...
But what should be the new Harmony ID value? we better give it a good thought so that we don’t change it again!
harmony documentation says:
var harmony = HarmonyInstance.Create("com.company.project.product");
The id should be in reverse domain notation and must be unique. In order to understand and react on existing patches of others, all patches in Harmony are bound to that id.
Issue Analytics
- State:
- Created 3 years ago
- Comments:14 (9 by maintainers)
Top GitHub Comments
@kvakvs @krzychu124 Do you all agree with
me.tmpe
?yeah, I’ll send PR 😉