Improve code readability by simplifying debug logging

In the current code, there are a lot of such constructs:

#if DEBUG
    if (debug)
        Log._Debug("Whatever");
#endif

They are sometimes repeated very often, after each line (e.g. JunctionRestrictionsManager.cs). It’s almost impossible to read and to understand code like that.

Suggested improvements:

• The Log._Debug method already has the [Conditional("DEBUG")] attribute, so no need in #if DEBUG / #endif region at all
• The if (debug) check can actually be transferred into the Log._Debug method

After those improvements, the logging code becomes as simple as that:

        Log._Debug("Whatever");

It will make the code much more readable and won’t affect performance.

[dymanoid]

Yes, by “never” I mean not literally “not a single time in your life time” but rather “you can really go without it, and if not, then you surely know what you are doing”.

20 bytes for x86 and 24 bytes for x64 are the struct sizes where the jitter decides to switch from simple and fast CPU instructions (cheap copying) to a loop (expensive copying). Cheap copying is almost as fast as accessing by-reference.

[dymanoid]

Rule of thumb: don’t use in. If you still want to use it, see rule of thumb. Please read this SO question and the two most upvoted answers.

string.Format is even slower than string concatenation. Better to avoid both whenever possible.