Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Mod compatibility checker - null issue

See original GitHub issue

Subaru had this error on the mods incompatibility checker (LABS prior to PR #333) - only happened one time, I’m unable to reproduce it.

However, I’ll add some try/catch wrappers to the updates in #333 so future errors won’t impact end-users.

Note: Mac platform - Mac has known issues with Linq, we should avoid Linq wherever possible. I’ll try and rip out the Linq code from #333 - it’s only used in one place IIRC, a .last() somewhere.

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentNullException: Argument cannot be null.
Parameter name: source
  at System.Linq.Check.Source (System.Object source) [0x00000] in <filename unknown>:0 
  at System.Linq.Enumerable.ToArray[PublishedFileId] (IEnumerable`1 source) [0x00000] in <filename unknown>:0 
  at TrafficManager.Util.ModsCompatibilityChecker.GetUserModsList () [0x00000] in <filename unknown>:0 
  at TrafficManager.Util.ModsCompatibilityChecker..ctor () [0x00000] in <filename unknown>:0 
  at TrafficManager.TrafficManagerMod.OnGameIntroLoaded () [0x00000] in <filename unknown>:0 
  at TrafficManager.TrafficManagerMod.OnEnabled () [0x00000] in <filename unknown>:0 
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception

Issue Analytics

State:
Created 4 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

dymanoidcommented, Jun 20, 2019

I’m not sure the “massive performance issues” on Mac were caused by Linq. Rather by an inappropriate Linq usage 😄

@VictorPhilipp, can you give a particular example where Linq causes performance drop on Mac only? This is a very interesting topic.

@krzychu124, that field indeed can be null. The call into your code comes from Awake of the OptionsMainPanel. The ContentManagerPanel is a different object, thus it will be initialized independently from the options panel. The initialization order is not guaranteed.

0reactions

originalfoocommented, Jun 20, 2019

@dymanoid Check the updated code in #333 - that scenario should no longer be an issue as it no longer pulls mod list from or otherwise interacts with the ContentManagerPanel.