Reduce `MaxYieldVelocity`

In #662 the ‘cars stopping at yeild signs’ bug was solved so well that now vehicles on Yield roads enter junctions too smoothly with no visible difference to cars on Priority roads (other than that they’ll yield if necessary).

We can possibly alter MaxYieldVelocity global config var (and bump config version to make sure it gets pulled in to existing saves) to make vehicles slow down a little before entering junction so there’s some visible effect of the Yield sign working.

However, it might be better to have the Yield velocity be a function of road speed (same for Stop velocity too)? For example, Yield could be 60% of segment speed limit, Stop could be 30%? Values would need experimentation to find what looks best. There would likely need to be a min speed so they don’t just grind to a crawl.

[originalfoo]

Yup, i think MaxYieldVelocity is more of a hack due to the original implementation, and we should seek to abandon that setting.

Ideally approach speed should be based on factors such as:

• Road speed ( as you mentioned above )
• Turn angle ( mentioned earlier in this thread )
• Weather ( adverse weather should play a role if Road condition has a bigger impact on vehicle speed option enabled - although this already would affect the road speed so probably no need to check separately )
• Vehicle size ( larger vehicles slow down more? )
• Reckless drivers ( don’t slow down )

[krzychu124]

Annnnd, additionally… there’s some fast math functions that can make the calcs eat less CPU:

https://github.com/Quistar-LAB/EManagersLib/blob/master/EMath.cs

No need, most of such “vanilla” functions are inlined because of FPS Booster patch introduced in v 0.7 - you won’t see any difference or better, there is a chance that patched vanilla will be faster than this custom solution 😅

The videos in that issue do show the yielding and stopping but they don’t have different speeds for yielding when there’s no other traffic to force a speed change or a complete stop.

Because in code perspective they don’t yield when target and incoming vehicles are on priority road. That’s a missing bit + that behaviour does not work on junctions with traffic lights yet. It looks like I found a bug in the code that completely ignores MaxYieldVelocity when Simulation Accuracy is >= Medium. It works correctly on Low and Very Low… Time to fix it 😄

Low Simulation Accuracy, at higher setting vehicles on the left side don’t care

https://user-images.githubusercontent.com/19638970/153069855-001ce4ed-efaa-4c60-8c8b-ca3b37c00392.mp4