WaitConditionBuilder constructor never sets the condition in the builder despite taking it as an argument

Citrus Version 3.2.1

Expected behavior The constructor should set the condition in the underlying builder.

Actual behavior The constructor does not set the condition in the underlying builder, it has to be set manually.

Test case sample

Wait.Builder builder = new Wait.Builder()
        .time(timeout);
WaitActionConditionBuilder waitActionConditionBuilder = new WaitActionConditionBuilder(condition, builder);

does not work. The condition will never actually be set. Instead,

Wait.Builder builder = new Wait.Builder()
        .time(timeout)
        .condition(condition);

WaitActionConditionBuilder waitActionConditionBuilder = new WaitActionConditionBuilder(condition, waitBuilder);

has to be performed. This makes the argument condition in the WaitActionConditionBuilder useless. I’d propose to add a line builder.condition(condition) in the constructor of WaitConditionBuilder.

[bbortt]

@akuz0 just follow the steps proposed. make the constructor argument meaningful. test it using the code proposed (“assert condition is applied in constructor”).

[christophd]

@bbortt @akuz0 please have a look #875