RPC requests are getting cancelled
See original GitHub issueWallet version or commit SHA:
dev
branch (c8585ba)
Environment: Win 10 Home (64 bit) Version 1803 Build 17134.112
Prerequisites:
- At least one wallet imported to the app
Reproduction steps:
- Start Neon Wallet
- Click on “Login using a saved wallet” button
- Select your wallet, enter your passphrase and click on “Login” button
- Wait for some time having your wallet running in the background
I’ve observed that sometimes RPC requests are cancelled by Neon Wallet. This is going to cause issues with missing balances for specific assets. For example - 10 requests are triggered to fetch balances for 10 assets, 2 of them are cancelled - user is going to miss balances for 2 assets.
I’m guessing that this is probably caused because of longer response times from RPC nodes. I know that there is 5000ms
timeout defined while sending a transaction. Does it also apply to requests for fetching blocks and balances of assets from RPC nodes? If yes then maybe we should increase that timeout (neo.org
nodes are quite slow while it comes to response times and they time out very often) and in addition to that retry cancelled requests for getting block height and fetching balances?
Screenshots/Video:
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (5 by maintainers)
Top GitHub Comments
@drptbl thats not true anymore… there have been several changes over the past few weeks and making one call is now one of them leveraging neo-js
api.nep5.getTokenBalances
instead of one call per tokenThis timeout was increased to
30000
in version3.10.0
. Worth giving it another shot? (after upgrading neon-js) @drptbl