First impressions & suggestions
See original GitHub issueThere are some minor things that occurred to me when taking my first steps with nox-poetry:
-
the distribution_format argument to installroot needs to be of type DistributionFormat; it would be handy if it would accept strings (‘sdist’, ‘wheel’) as well.
-
installroot requires distribution_format to be passed as a keyword argument. I didn’t know this was possible and this is the first time I encountered this so it confused me.
-
Perhaps a (slightly) nicer way to integrate with nox is to offer a replacement for
nox.session
. Then one could do:from nox_poetry import session, SDIST @session() def unit(session): session.installroot(SDIST) session.install('pytest') session.run('pytest', 'tests')
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:7 (5 by maintainers)
Top Results From Across the Web
How to Make a Good First Impression: 14 Tips to Try
Arrive early. Be empathetic. Actively listen. Be mindful of your body language and posture. Modulate your pitch and tone of voice. Choose your ......
Read more >How to Make a Great First Impression
What the Experts Say · Prepare talking points · Be aware of your body language · Play to your strengths · Find something...
Read more >6 tips for making a good first impression
6 tips for making a good first impression · 1. Know your audience · 2. Exude confidence · 3. Field questions gracefully ·...
Read more >8 killer ways to make a good first impression - Ladders
1. Dress to impress · 2. Wipe that look off your face · 3. Appear Interested · 4. Politeness matters · 5. Offer...
Read more >The Ultimate Guide To Making a First Impression (even online)
How long does it take to make a first impression? Research shows that most people make a first impression of a person within...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Maybe the Nox maintainers would be open to integrating nox-poetry into Nox, seeing as Poetry seems to be gaining significant traction?
Sorry, I was thinking out loud and not making much sense. The main idea was to subclass nox.Session and simply extend/override. I was assuming the session decorator would allow using the nox-poetry Session class, but alas the Nox architecture doesn’t allow for that.
❤️ Love it!
That makes perfect sense. Encountering this for the first time just confused me. Perhaps add something to the README if more people complain about is? As for the wordy distribution_format, you could consider renaming it to format.
Personally, I’d prefer the Nox API to remain based on packaging standards, possibly with extension points for specific tool support. Also, I feel that nox-poetry needs to mature a little more before I would suggest changes to Nox. Poetry is also still evolving quite significantly, and I’m still hoping for a situation where Poetry’s feature set would render nox-poetry superfluous.
Sounds good.
Yes, I’ve considered that. It’s a good name in the context of
build_package
, a little less so in the context ofinstallroot
. But acceptable, I guess. However, we’d need to deprecate the old keyword argument. There’s some prior art in the codebase for that.PR(s) welcome 😃