question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Code completion doesn't respect allCommitCharacters

See original GitHub issue

Here’s the documentation from lsp spec:

	/**
	 * The list of all possible characters that commit a completion. This field can be used
	 * if clients don't support individual commit characters per completion item. See
	 * `ClientCapabilities.textDocument.completion.completionItem.commitCharactersSupport`.
	 *
	 * If a server provides both `allCommitCharacters` and commit characters on an individual
	 * completion item the ones on the completion item win.
	 *
	 * @since 3.2.0
	 */
	allCommitCharacters?: string[];

clangd started sending this out in its completionProvider field recently, but it seems like CoC doesn’t fall back to allCommitCharacters when completionItem doesn’t have individual commit characters.

This results in only being able to commit a completion with hitting enter.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
fannheywardcommented, Feb 19, 2020

Correct me if I’m wrong. coc already added commitCharactersSupport, but not fallback to use allCommitCharacters?

0reactions
fannheywardcommented, Feb 19, 2020

Merged.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Commit characters don't work when inside parens (TypeScript)
Unfortunately we can't reliably compute commit characters on the VS Code extension side. This needs to come from the TypeScript server.
Read more >
VS Code tips — Commit characters - YouTube
Today's VS Code tip: Commit charactersCommit characters accept the current suggestion when typedThe exact set of commit character vary based ...
Read more >
Push rules - GitLab Docs
This push rule requires a Signed-off-by: trailer in every commit message, and rejects any commits that lack it. Validate branch names. To validate...
Read more >
Git bash-completion with filename support? - Stack Overflow
It works for most subcommands, i.e. hg add <tab><tab> will only list untracked files. It is really handy. The bash script from git...
Read more >
GoLand 2018.1 Release Notes | Knowledge Base
GoLand 2018.1 Release Notes ; Version Control, Bug, IDEA-187108, Commit action does not respect file selection in Local changes ; Bug, IDEA-187101, EAP...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found