Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Publish the react 16 compatible version to NPM

See original GitHub issue

Hi @clauderic!

I see you’ve updated this library’s peerDeps to be compatible with react 16. Can you publish a version containing that change to NPM?

Issue Analytics

State:
Created 6 years ago
Comments:5

Top GitHub Comments

1reaction

cyrus-zacommented, Mar 15, 2018

It was due to not uninstalling react-sortable-hoc yet. All good here

On Thu, Mar 15, 2018, 02:04 Kieran Sedgwick notifications@github.com wrote:

@cyrus-za https://github.com/cyrus-za You’re mistaken. Perhaps you installed the wrong version? A fresh install of npm install amo-react-sortable has this in the package.json:

“peerDependencies”: { “react”: “^0.14.0 || ^15.0.0 || ^16.0.0”, “react-dom”: “^0.14.0 || ^15.0.0 || ^16.0.0” },

Let me know if I’ve overlooked something.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clauderic/react-sortable-hoc/issues/351#issuecomment-373215572, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwqZWzitphdFgcsnN975xtGWebHH4ynks5tea_9gaJpZM4Sk3aT .

0reactions

sedgecommented, Mar 15, 2018

@cyrus-za You’re mistaken. Perhaps you installed the wrong version? A fresh install of npm install amo-react-sortable has this in the package.json:

  "peerDependencies": {
    "react": "^0.14.0 || ^15.0.0 || ^16.0.0",
    "react-dom": "^0.14.0 || ^15.0.0 || ^16.0.0"
  },

Let me know if I’ve overlooked something.

Edit: Just saw that I didn’t change the repository link in the package.json file. This doesn’t affect using the package, but does obscure where the code came from. It lives here