--skip-rebase should be the default

I want to provide a small, but important feedback, as it bit me really hard and I believe it’ll bite many other users.

First and foremost, I am using clean-css and now the new clean-css-cli for CSS minification. This is the reference tool for this job, and congratulation for making this huge achievement!

However, the default URL rebasing is an extremely bug prone feature. Running the tool with one path in development (where rebasing might not trigger) might produce a totally different result compared to running in from a different path, or when bundling files for production in a script, because of the “smart” auto rebasing option.

I recommend switching that option off by default (as in making --skip-rebase the default) as it’ll bite many other users who just prefer to use this tool as a CSS minifier, without any of the path relative smart rebasing magic (personally I’d categorise that feature as -O2 or even -O3).

[hyperknot]

Sure, no problem, I’ve finally found the right switch and if people run into the same problem they might find this issue by Google.

On 19 April 2017 at 20:52, Jakub Pawlowicz [e-mail] wrote:

Got it - since it’d be a breaking change it needs to wait until the next major release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jakubpawlowicz/clean-css-cli/issues/6#issuecomment-295389158, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeKj3q4z3arYGbyyXsRUyxB7H8Zfd_0ks5rxlfkgaJpZM4M9_Qg .

[jakubpawlowicz]

And rebasing will be off by default in clean-css-cli v5 due soon.