Runtime error: Cannot read property 'bind' of undefined in latest Clean-CSS 5.0

Runtime error: Cannot read property ‘bind’ of undefined in latest Clean-CSS 5.0

Actual error stack:

Client CSS build error TypeError: Cannot read property 'bind' of undefined
  at overrideProperties (/home/vlado/dev/pigallery/node_modules/clean-css/lib/optimizer/level-2/properties/override-properties.js:468:53)
  at optimizeProperties (/home/vlado/dev/pigallery/node_modules/clean-css/lib/optimizer/level-2/properties/optimize.js:33:5)
  at reduceSelector (/home/vlado/dev/pigallery/node_modules/clean-css/lib/optimizer/level-2/reduce-non-adjacent.js:161:3)
  at reduceSimpleNonAdjacentCases (/home/vlado/dev/pigallery/node_modules/clean-css/lib/optimizer/level-2/reduce-non-adjacent.js:82:5)
  at reduceNonAdjacent (/home/vlado/dev/pigallery/node_modules/clean-css/lib/optimizer/level-2/reduce-non-adjacent.js:54:3)
  at level2Optimize (/home/vlado/dev/pigallery/node_modules/clean-css/lib/optimizer/level-2/optimize.js:89:5)
  at optimize (/home/vlado/dev/pigallery/node_modules/clean-css/lib/clean.js:221:5)
  at /home/vlado/dev/pigallery/node_modules/clean-css/lib/clean.js:194:29
  at /home/vlado/dev/pigallery/node_modules/clean-css/lib/reader/read-sources.js:26:64
  at loadOriginalSources (/home/vlado/dev/pigallery/node_modules/clean-css/lib/reader/load-original-sources.js:26:5)

Code where this happens is in clean-css/lib/optimizer/level-2/properties/override-properties.js

mayOverride = configuration[right.name].canOverride;
overridable = everyValuesPair(mayOverride.bind(null, validator), left, right);

I’ve added a debug output just to check values:

console.log('clean-css debug:', right.name, configuration[right.name], configuration[right.name].canOverride);

And for most entries it passes without errors. However, for right.name === clip, there are no defaults and property canOverride is not defined.

clean-css debug: clip {
  valueOptimizers: [
    [Function: whitespace],
    [Function: fraction],
    [Function: precision],
    [Function: unit],
    [Function: zero]
  ]
} undefined

Configuration is:

  clean = new CleanCSS({ level: { 1: { all: true }, 2: { all: true } } });

And actual CSS is at: https://github.com/vladmandic/pigallery/blob/master/client/pigallery.css

I’ve added a quick workaround with, but that’s not a solution:

  overridable = mayOverride ? everyValuesPair(mayOverride.bind(null, validator), left, right) : true;

Environment

• Clean-CSS 5.0
• NodeJS 15.7.0
• OS: Ubuntu 20.10

[vladmandic]

confirmed as resolved - thanks!

[jakubpawlowicz]

Thanks @vladmandic - the fix is ready. It was only possible to see it once files were combined, but actually the reduced test case was very very short. Going to release 5.0.1 shortly.