Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Format Timestamp for DateTime64 Parameter with millisecond precision not working

See original GitHub issue

When setting a Timestamp for a DateTime64 parameter with millisecond precision on a prepared statement the milliseconds are lost when inserting.

This issue occurs for clickhouse-jdbc version 0.3.0


Create the following table

    date DateTime64(3),
    value Decimal64(8)

And then insert a record with a Timestamp with millisecond precision:

  ClickHouseConnection conn = getConnection();
  PreparedStatement stmt = conn.prepareStatement("INSERT INTO test (date, value) VALUES (?, ?);");
  long date = 1617028535604L; // Mon Mar 29 2021 14:35:35.604
  stmt.setTimestamp(4, new Timestamp(date));

When selecting the inserted record you will see that milliseconds are lost, the DateTime64 returned by ClickHouse is then 2021-03-29 16:35:35.000 but it should be 2021-03-29 16:35:35.604.

I have pinpointed the problem to the formatTimestamp function

You can see with the following simple example:

    public static void main(String[] args) {
        long date = 1617028535604L; // Mon Mar 29 2021 14:35:35.604
        Timestamp ts = new Timestamp(date);
        String formatted = ClickHouseValueFormatter.formatTimestamp(ts, TimeZone.getTimeZone("UTC"));
        System.out.println("SQL Timestamp: " + ts);
        System.out.println("ClickHouse JDBC Formatted Timestamp: " + formatted);

This will output:

SQL Timestamp: 2021-03-29 16:35:35.604
ClickHouse JDBC Formatted Timestamp: 2021-03-29 14:35:35

But the ClickHouse JDBC Formatted Timestamp should be 2021-03-29 14:35:35.604

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:3
  • Comments:16 (1 by maintainers)

github_iconTop GitHub Comments

zhicwucommented, Sep 8, 2021

To summarize what we discussed and items on my list regarding this:

  1. client-side prepared statement(using parse handler) aiming to support simple scenarios only For example:

    • client sends query insert into my_table(c1, c3, c5) values(1, ?, ?) along with 2 parameters
    • jdbc driver parses the query to understand its structure, and executes select c3, c5 from my_table where 1=0 Format TabSeparatedWithNamesAndTypes to get column types
    • and then jdbc driver executes substituted query like insert into my_table(c1, c3, c5) values(1, 'a', '2021-08-29 12:12:12.123456') accordingly
  2. batch insert optimization to avoid common mistakes Apparently the parsing and extra query will slow things down, but it can help to improve performance of batch insert. Let’s reuse above example here, if we change the query to below, we no longer have to execute many inserts but only one with streamed data:

    insert into my_table(c1, c3, c5)
    select 1 as c1, c3, c5
    from input('c3 String, c5 DateTime64(6)')
    Format RowBinary
  3. named parameter with or without type - try not to be smart and let the caller to decide Above two are workarounds for clickhouse-jdbc, the JDBC driver. Named parameter on the other hand will be applied to both jdbc driver and the upcoming clickhouse-client, successor of extended API, which I believe is a better way to address the issue.

    // localhost:9100
    ClickHouseNode server = ClickHouseNode.builder().withPort(ClickHouseProtocol.GRPC).build();
    // prefer to use grpc implementation
    try (ClickHouseClient client = ClickHouseClient.newInstance(ClickHouseProtocol.GRPC)) {
      // reusable request object, an immutable copy will be made when calling its send() method
      Mutation request = client.connect(server).write().format(ClickHouseFormat.RowBinary);
      Map<String, ClickHouseValue> namedParams = new HashMap<>();
      namedParams.put("c3", ClickHouseStringValue.of("a"));
      namedParams.put("c5", ClickHouseDateTimeValue.of("2021-08-29 12:12:12.123456789"));
      // named parameter without type
      request.sql("insert into my_table(c1, c3, c5) values(1, :c3, :c5)").params(namedParams).send();
      // with type
      request.sql("insert into my_table(c1, c3, c5) values(2, :c3(String), :c5(DateTime64(6))")
        // parameters can also be specified as array / collection
        .params(ClickHouseStringValue.of("a"), ClickHouseDateTimeValue.of(;
      // batch insert using raw data
        .sql("insert into my_table(c1, c3, c5) select 3 as c1, c3, c5 from input('c3 String, c5 DateTime64(6)')")
  4. parsing errors Two issues:

    1. parsing date time with fraction is not supported(see this) - we probably should try something like below:
    static final DateTimeFormatter DATETIME_FORMATTER = new DateTimeFormatterBuilder()
            .appendPattern("yyyy-MM-dd HH:mm:ss").appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, true).toFormatter();
    1. has problem to distinguish parameter placeholder ? and conditional operator ?:(see this), which is a known issue. Named parameter does not have this issue as of now.
den-cranecommented, Aug 28, 2021

I think it should be implemented in CH

Read more comments on GitHub >

github_iconTop Results From Across the Web

DateTime64 | ClickHouse Docs
DateTime64. Allows to store an instant in time, that can be expressed as a calendar date and a time of a day, with...
Read more >
python datetime to float with millisecond precision [duplicate]
In Python 3 you can use: timestamp (and fromtimestamp for the inverse). Example ...
Read more >
Time series / date functionality — pandas 1.5.2 documentation
Rounding during conversion from float to high precision Timestamp is unavoidable. The only way to achieve exact precision is to use a fixed-width...
Read more >
Datetimes and Timedeltas — NumPy v1.23 Manual
The date units are years ('Y'), months ('M'), weeks ('W'), and days ('D'), while the time units are hours ('h'), minutes ('m'), seconds...
Read more >
TO_TIMESTAMP maps to one of the other timestamp functions, based on the ... it does not accept a DATE inside a VARIANT. Optional:...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found