Adapters versions should be semver. Patch number can differ from `dbt-core`
See original GitHub issueHey team, thanks for your great work maintaining dbt-clickhouse
!
It looks like you cut a release of dbt-clickhouse
a week ago, v1.1.0.1, which doesn’t adhere to semantic versioning. As of v1.0+, dbt-core
expects installed adapter plugins to:
- be valid semantic versions
- match the
dbt-core
semantic version in its Major + Minor components — where the Patch number is allowed to differ
That logic lives here in dbt-core
.
Docs on this: https://docs.getdbt.com/docs/core-versions#how-dbt-core-uses-semantic-versioning
In short, I’d recommend that you make two changes:
- Loosen the
dbt-core
version dependency to be at the minor version level, instead of the patch level, by changing this line todbt-core~={dbt_version}
- Re-releasing v1.1.0.1 as v1.1.1
Let me or @dataders know if you have any questions!
Issue Analytics
- State:
- Created a year ago
- Comments:7
Top Results From Across the Web
About dbt Core versions | dbt Developer Hub
Patch version numbers are likely to be different between dbt-core and the adapter plugin(s) you have installed. Major and minor version numbers ...
Read more >Adapter Maintainers: Upgrading to dbt-core 1.2.0 #5468
This discussion is for communicating to adapter maintainers the scope of work needed to make use of the changes in 1.2.0. If you...
Read more >Does Semantic Versioning allow 4 components in version ...
Thus, we use the 4th group for binary compatibility (you can hot-patch the system) and the 3rd for source compatibility (you need to...
Read more >rusty_v8 vs semver - compare differences and reviews? | LibHunt
Some faction mods etc. will use semver. Meaning that, unless the major version changes, it's safe to update. Unfortunately, this isn't always reliable....
Read more >Use Semantic Versioning and Give Your Version Numbers ...
Precedence MUST be calculated by separating the version into major, minor, patch and pre-release identifiers in that order (Build metadata does ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Hi @1c7, sorry for the late reply, I will update the version to 1.1.2, there’s no need to fork.
@guykoh Thanks!