Replace Flask-OAuthlib with Authlib
See original GitHub issuecg
is using Flask-Dance and Scout is using Flask-OAuth to handle oauth requests. The latter has been abandoned in favour of Flask-Dance: https://github.com/mitsuhiko/flask-oauth
The problem that arises is that Flask-Oauth requires oauthlib<3.0.0 but Flask-Dance’s requirement requests-oauthlib requires oauthlib>=3.0.0. https://github.com/mitsuhiko/flask-oauth/blob/master/setup.py#L31 https://github.com/requests/requests-oauthlib/blob/master/requirements.txt#L2 Welcome to dependency hell! 😃 What are the consequences? Well, for cg it means that all tests are failing unless we take scout-browser away as a dependency.
After investigating this (https://medium.com/knerd/the-nine-circles-of-python-dependency-hell-481d53e3e025), a solution is that scout would upgrade to Flask-Dance at some point. Another is to speed up the uncoupling of cg and scout so you don’t have to upgrade.
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (6 by maintainers)
Top GitHub Comments
I’ll start to have a look at this one today
Uncoupling of scout and cg has not even started yet 😉
The temporary solution to get cg to work again is to remove scout-browser as a dependency and install it separately before we install cg. Fixed here: https://github.com/Clinical-Genomics/servers/pull/55