question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

General discussion about 0.96 priorities

See original GitHub issue

@Pankraty @b0bi79

Firstly, let’s wait for 0.95 to be adopted widely and wait for the first wave of regressions to be sorted out.

Then the big tasks I would like to focus on for 0.96 are:

  • Pivot table formats: We need to explicitly list all the pivot table formats and have test files for each individual format, as well as combinations of them. At the moment I have only combinations and makes the reverse-engineering of them almost impossible.
  • Calculation engine context, for evaluation of e.g. =ROW() #1415
  • Formula repository / caching: #1201 addresses this already.
  • XLLoadOptions to set some stuff, e.g. user-specified locale (#1367). Discussion at #1407
  • Support for external references, even if only partial support. The workbooks at least should not break.
  • Refactor pivot tables into pivot sources + pivot tables
  • Support pivot table calculated formulas (dependent on previous point).
  • Protection: Align workbook and worksheet protection. Implement newer protection methods.
  • Improve loading of cell data. At the moment we parse the OpenXML Cell’s text value, and then ToString() it immediately. I think we should delay the parsing of the text value until the cell’s value has to be recalculated.

Before any of you just start writing code, let’s just chat. I have some PRs and branches locally that already address some of these issues.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
Pankratycommented, Apr 17, 2020

I was thinking about refactoring saving/loading logic.

  1. First, detach saving/loading from XLWorkbook class into separate classes implementing IXLWorkbookReader and IXLWorkbookWriter.
  2. Then, provide the alternative implementations
    • XLInMemoryWorkbookReader, XLInMemoryWorkbookWriter - basically, the current implementation, fully initializing the entire workbook in memory. Maybe it has to take care of #912 also.
    • XLReadOnlyWorkbookReader - a fast implementation with lazy loading of needed sections in a read-only mode. It may help with #781, #1345, and many other scenarios where we only need to read some data and do not really care about formats, data validations, etc. This cannot work without accessing the original stream by design.
    • XLStrictModeWorkbookReader, XLStrictModeWorkbookWriter - to operate with workbooks using strict mode (#1378).

This would also open a window for supporting different formats, maybe sometime in the future.

1reaction
timuniecommented, Apr 22, 2021

Hi ClosedXML Team,

first of all this is a great library and it makes my life really easier 👍 . For me it would be a great enhancement if I could pick from named predefined styles. I read a template with custom CellStyles in it and want to apply those. I think there is already a ticket open for this #1290 .

Happy coding Tim

Read more comments on GitHub >

github_iconTop Results From Across the Web

Narrative in 0.96 aka Movie Night With David
Answering all the questions and making every noun closely related to every other makes the world feel very small (see: the pitfalls of...
Read more >
Guidelines and clinical priority setting during the COVID-19 ...
The probability of reporting that their patients had been given lower priority increased with lower age (Exp (B) = 0.97, 95% CI =...
Read more >
How well do healthcare professionals know of the priorities ...
Patients are invited to prioritise between four universal health outcomes: extending life, maintaining independence, reducing or eliminating pain and reducing ...
Read more >
What matters to patients? A timely question for value-based ...
Our healthcare system is moving towards patient-centered and value-based care models that prioritize health outcomes that matter to patients.
Read more >
Social norms explain prioritization of climate policy
4 General discussion. Social norms predict and influence public prioritization of climate policy. In Study 1, people's prioritization of climate ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found