Table name not protected against spaces

Read and complete the full issue template

Do not randomly delete sections. They are here for a reason.

Do you want to request a feature or report a bug?

• Bug
• Feature
• Question

Did you test against the latest CI build?

• Yes
• No

If you answered No, please test with the latest development build first.

Version of ClosedXML

0.97.0

What is the current behavior?

Allows empty space in table names

What is the expected behavior or new feature?

When you give a name to a table the code protect against starting with number or repeated names, but don’t protected against space The expected behavior is to give an error

Is this a regression from the previous version?

I don’t know is my first attempt to use the library

[jahav]

@NickNack2020

I think it would be better to reject invalid name with an exception. Name of a table is not just an identifier, but it can also be used formulas structured references (e.g. SUM(SalesTable[Profit])).

I am in favour of simple, understandable interfaces and contracts and principle of least surprise. Having a name sanitizer inside is not in line with that.

I would therefore refuse any invalid table names. We already throw an exception There is already a table names 'Xyz' when if someone tries to add a table with duplicate name. This only enhances the contract to be correct.

Please add a note/mitigation about change to the https://github.com/ClosedXML/ClosedXML/blob/develop/docs/migrations/migrate-to-0.101.rst + info in XML doc.

Spec says

A string representing the name of the table. This is the name that shall be used in formula references, and displayed in the UI to the spreadsheet user. This name shall not have any spaces in it, and it shall be unique amongst all other displayNames and definedNames in the workbook. The character lengths and restrictions are the same as for definedNames. See SpreadsheetML Reference - Workbook definedNames section for details

[ruirodrigues1971]

In the scenario that I was using was important that the name is correct. External System —> table names with spaces ----> closedXML Changing table names inside closedXML is a very dangerous solution in my opinion… The probability to think in every scenarios that the bad name (with spaces) can be used in the code can be huge…

I think the throwing error is the most correct. Is important the code has a coherent answer to dev errors. But this is my opinion.