co2 emissions estimation incoherent between LUT and UI

Preflight Checklist

• [ x] I have read the Contributing Guidelines for this project.
• [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

• Operating System:
  • macOS 10.13.6
• Browser:
  • Chrome

Expected Behavior

I would expect for the same time window selected for the billing report (AWS), to obtain the same amount of CO2 total emissions either via using the LUT or via using the UI.

Actual Behavior

The LUT estimation is way bigger, by a factor of 10k

Any help on ensuring the LUT is properly used ?

I just multiply the usageAmount by the CO2e factor…

If i look at the code of the following code of the UnknownEstimator

export default class UnknownEstimator implements IFootprintEstimator {
  constructor(private estimateKilowattHoursBy: EstimateUnknownUsageBy) {}

  estimate(
    data: UnknownUsage[],
    region: string,
    emissionsFactors: CloudConstantsEmissionsFactors,
    constants: CloudConstants,
  ): FootprintEstimate[] {
    return data.map((data: UnknownUsage) => {
      const estimatedKilowattHours = this.estimateKilowattHours(
        data,
        constants.kilowattHoursByServiceAndUsageUnit,
      )
      const estimatedCo2eEmissions = estimateCo2(
        estimatedKilowattHours,
        region,
        emissionsFactors,
      )
      return {
        timestamp: data.timestamp,
        kilowattHours: estimatedKilowattHours,
        co2e: estimatedCo2eEmissions,
        usesAverageCPUConstant: false,
      }
    })
  }

  private estimateKilowattHours(
    unknownUsage: UnknownUsage,
    kilowattHoursByServiceAndUsageUnit: KilowattHoursByServiceAndUsageUnit,
  ): number {
    const serviceAndUsageUnit =
      kilowattHoursByServiceAndUsageUnit[unknownUsage.service] &&
      kilowattHoursByServiceAndUsageUnit[unknownUsage.service][
        unknownUsage.usageUnit
      ]

    if (serviceAndUsageUnit)
      return (
        (serviceAndUsageUnit.kilowattHours /
          serviceAndUsageUnit[this.estimateKilowattHoursBy]) *
        unknownUsage[this.estimateKilowattHoursBy]
      )

    const totalForUsageUnit =
      kilowattHoursByServiceAndUsageUnit.total[unknownUsage.usageUnit]

    if (totalForUsageUnit)
      return (
        (totalForUsageUnit.kilowattHours /
          totalForUsageUnit[this.estimateKilowattHoursBy]) *
        unknownUsage[this.estimateKilowattHoursBy]
      )
    const totalKiloWattHours = this.getTotalFor(
      'kilowattHours',
      kilowattHoursByServiceAndUsageUnit,
    )
    const totalCost = this.getTotalFor(
      this.estimateKilowattHoursBy,
      kilowattHoursByServiceAndUsageUnit,
    )

    return (
      (totalKiloWattHours / totalCost) *
      unknownUsage[this.estimateKilowattHoursBy]
    )
  }

my understanding, it is that even if for the unknown row, we do not find a “UsageUnit”, we would still provide an estimation via these lines

 const totalKiloWattHours = this.getTotalFor(
      'kilowattHours',
      kilowattHoursByServiceAndUsageUnit,
    )
    const totalCost = this.getTotalFor(
      this.estimateKilowattHoursBy,
      kilowattHoursByServiceAndUsageUnit,
    )

    return (
      (totalKiloWattHours / totalCost) *
      unknownUsage[this.estimateKilowattHoursBy]
    )

Is it not misaligned with the methodology description where we only provide an estimate if there is a match at one of the following two levels

• servicename & usageunit
• usageunit

?

[lllllAlexlllll]

@4upz Hey Arik, Thank you for dealing with the bug. The issue is a significant obstacle for our Carbon Footprint Tracking project. We would like to offer some help since we have an experienced Node JS developer on our team. Would you like to collaborate on this?

[ericksod]

Thanks all - we will also take a look at this. Additionally we got a request to look at how this works with Unknown usage types, see here: https://groups.google.com/g/cloud-carbon-footprint/c/RrrYH8qQVH0