Use a github token for checksums?
See original GitHub issueWhat is missing?
I think the role should support the use of a Github Token to avoid rate limiting.
Currently, I keep running into a 400 (Bad Request) errors when I deploy lots of nodes in parallel. That seems to rate-limiting from Github’s end. In my environment, I cd to about 20 customer setups, each of them may have multiple nodes. The part we are continuously deploying involves a basic monitoring setup on each node (including the node-exporter).
Why do we need it?
We run Ansible in a container, shared-nothing so to speak. The container gets invoked during CI (merge to main branch).
There is no caching between builds, it seems to work well. There are no side effects, except for this part where each run makes requests against Github (API) resources and seems to run into the rate-limit eventually.
I was digging around, it seems that both of these blocks happen every time (unless I download the binary myself):
Checksum gathering: https://github.com/cloudalchemy/ansible-node-exporter/blob/b9cb0eeccfaa104af5ba23e80c4104fef6814d93/tasks/preflight.yml#L98-L110
I would think I wouldn’t download anything — unless I really needed? Do you have any thoughts on changing that?
Environment
-
Role version:
0.21.3
-
Ansible version information:
root@5c649b77871a:/ansible-all-the-things# ansible --version
ansible 2.9.8
config file = /ansible-all-the-things/ansible.cfg
configured module search path = ['/ansible-all-the-things/library']
ansible python module location = /usr/local/lib/python3.7/site-packages/ansible
executable location = /usr/local/bin/ansible
python version = 3.7.8 (default, Jun 30 2020, 18:36:05) [GCC 8.3.0]
Anything else we need to know?:
Issue Analytics
- State:
- Created 3 years ago
- Comments:12 (11 by maintainers)
I’ll dig around. Can you re-open this, or do I need to make another ticket?
Replacing
lookup()
withuri
:Yields the
400
— but not sure whereAuthorization
header is introduced?