Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Broken thriftpy dependency with python3 when installing v0.14.2

See original GitHub issue

Hi. With upgrade to 0.14.2 there seems to be broken thriftpy dependency. Here are some data how to reproduce the bug.

Installation

[jask@hal3042 ~]$ virtualenv -p /usr/bin/python3 venv
Already using interpreter /usr/bin/python3
Using base prefix '/usr'
New python executable in /home/jask/venv/bin/python3
Also creating executable in /home/jask/venv/bin/python
Installing setuptools, pip, wheel...done.

[jask@hal3042 ~]$ ./venv/bin/pip install impyla
Collecting impyla
Collecting thrift>=0.9.3 (from impyla)
Collecting bitarray (from impyla)
Collecting six (from impyla)
  Using cached https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Installing collected packages: six, thrift, bitarray, impyla
Successfully installed bitarray-0.8.3 impyla-0.14.2 six-1.12.0 thrift-0.11.0

Run

[jask@hal3042 ~]$ ./venv/bin/python
Python 3.7.2 (default, Jan 16 2019, 19:49:22) 
[GCC 8.2.1 20181215 (Red Hat 8.2.1-6)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>> from impala.dbapi import connect
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jask/venv/lib/python3.7/site-packages/impala/dbapi.py", line 28, in <module>
    import impala.hiveserver2 as hs2
  File "/home/jask/venv/lib/python3.7/site-packages/impala/hiveserver2.py", line 33, in <module>
    from impala._thrift_api import (
  File "/home/jask/venv/lib/python3.7/site-packages/impala/_thrift_api.py", line 61, in <module>
    from thriftpy import load
ModuleNotFoundError: No module named 'thriftpy'

Issue Analytics

State:
Created 5 years ago
Reactions:2
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

jirislavcommented, Feb 6, 2019

I think build tests would be useful in this case as this would not happen next time.

0reactions

AbdealiLoKocommented, Aug 26, 2020

I wonder if thriftpy2 is needed anymore for py3+ ? From what I see in: https://github.com/cloudera/impyla/blob/0284cc0850a1acf53507ba1366022fc36e6df517/impala/_thrift_api.py#L14-L18

It seems to indicate that it is only a compatibility layer until thrift supports py3. As per my understanding, Thrift currently does support py3, so maybe this compat layer can just be removed now ?