Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
URLs with encoded characters not handled properly.
See original GitHub issueIf I have an asset with a filename test file.jpg the corresponding url is /test%20file.jpg, which is correct. However, getAssetFromKV tries to access it as test%20file.jpg which does not exist and fails.
the URL constructor converts all spaces not already encoded to %20 automatically, so a simplistic solution would be running decodeURI here after the url was already parsed with URL:
https://github.com/cloudflare/kv-asset-handler/blob/d4fa91fae1806e30270dcc5f39f581ea37362a59/src/index.ts#L101
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (4 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
ooohhh - very interesting.
I’ve become so conditioned to respond to URL encoding issues with a recommendation to polyfill that I didn’t actually read your report.
Your diagnosis seems correct and using
decodeURIshould fix 👍Happy to accept a PR or we can add this to our list of things to address.
This will be fixed shortly in 0.0.11.