[Bug]: Not specifying a label on an AttributeEditor definition throws off alignment

Browser

No response

Package version

v3.0.118

React version

v18.2.0

Description

AttributeEditorProps.FieldDefinition permits for an undefined label, but if you do not define a label then the alignment of the fields is thrown off. As show below

Source code

<AttributeEditor
  addButtonText="Add new item"
  definition={[
    {
      label: "Key",
      control: (item, index) => (
        <Input value={item.key} placeholder="Enter key" />
      )
    },
    {
      control: (item, index) => (
        <Input value={item.value} placeholder="Enter value" />
      )
    }
  ]}
  removeButtonText="Remove"
  empty="No items associated with the resource."
/>

Reproduction

https://codesandbox.io/s/gallant-voice-m8r48d

Code of Conduct

• I agree to follow this project’s Code of Conduct
• I checked the current issues for duplicate problems

[just-boris]

Yes, we are likely to change type definitions when we will be able to.

Closing the request, because currently we have no major version release planned

[connorlanigan]

I see. In that case I’d recommend to not wrap the Attribute Editor in a FormField, since most of the functionality is also exposed on the Attribute Editor directly as part of the definition (e.g. constraint text, error state/text, info links).

The Typescript interface indeed currently does not enforce the requirement for a label to be present, but this cannot be changed in a backwards-compatible way, so it will not be updated in the current major version.