Boolean values should not be quoted in output
See original GitHub issueWhen outputting to YAML or JSON, boolean values should not have quotes around them. An output file will produce E3012 errors when ran through cfn-lint
because of this. See: https://github.com/awslabs/cfn-python-lint/issues/260 for more details on why its not a warning.
Changing the validators.boolean
function to return bool values, rather than strings would correct this issue. I can make a PR for this, but I wanted to discuss any possible repercussions first, since all these types would need to be verified.
Issue Analytics
- State:
- Created 5 years ago
- Reactions:12
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Can/should boolean values be passed in json with quotes?
Short answer, yes that is the proper way to send the JSON. You should not be placing anything other than a string inside...
Read more >Why is it sometimes 'False' or 'True' and others ... - Codecademy
Text in quotes are treated as Strings, while “True” or “False” without the quotations are treated as Boolean variables. They are different data...
Read more >Inaccurate sync error message when template value is passed ...
I've pasted the output of argocd version. Describe the bug When a boolean value is used in the environment v...
Read more >Boolean value to the condition in this conditional statement
You are not setting the value of 'x' equal to a string, you are currently setting it equal to the boolean value of...
Read more >Quoted Booleans - puppet-lint
Boolean values ( true and false ) behave differently when quoted ( 'true' and 'false' ), which can lead to a fair bit...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
This was fixed via #1409 with the use of adding the environment variable TROPO_REAL_BOOL=true. It was done this way to preserve backward compatibility for existing stacks and will be the default in troposphere 3.0.
I didn’t realize it was implying we need to set that environment variable, and not that troposphere itself set that environment variable. Of course that also made it difficult to find my answer in the documentation since the setting of environment variables are often not shown. Makes sense now.