GitHubUpdateManager() should use ConfigureAwait(false)

This is just a suggestion.

GitHubUpdateManager uses a few “await”, but it should be using ConfigureAwait(false):

Suggested Code Change:

using (var client = new HttpClient() { BaseAddress = baseAddress }) {
  client.DefaultRequestHeaders.UserAgent.Add(userAgent);
  var response = await client.GetAsync(releasesApiBuilder.ToString()).ConfigureAwait(false);
  response.EnsureSuccessStatusCode();

  var releases = SimpleJson.DeserializeObject<List<Release>>(await response.Content.ReadAsStringAsync().ConfigureAwait(false));

This change will avoid a deadlock in a scenario where the caller of GitHubUpdateManager() waits synchronously such as:

  var mgr = GetUpdateManagerAsync().GetAwaiter().GetResult();

If the caller uses the UI thread to invoke like this, the UI thread will wait for the task to finish, while GitHubUpdateManager() awaits a task and resume on the same UI thread. However, the UI thread cannot resume GitHubUpdateManager() because it’s already waiting.

[caesay]

This is now released in 2.7.34-pre

[caesay]

Thanks for the tip about CA2007, very helpful. This has been addressed in 0b8bcc19d650da1592a8cc26f7861b55a5a179bd and will be in the next release.