CC0057 : Unused parameters on extension methods

This is an open discussion but I think that CC0057 (remove unused parameters) should not be triggered on extension methods. sometimes, we have to add extension methods to existing class, even if we don’t use it. This a convenient method to get more coherence in client code.

        public static string RenderFooBar(this HtmlHelper helper)
        {
            // do something without helper
            return "footbar";
        }

Current output after fix applied (if it is a code fix bug)

        public static string RenderFooBar()
        {
            // do something without helper
            return "footbar";
        }

Please note that the project won’t compile after the code fix because RenderFooBar is no longer an extension method.

Expected output after fix applied (if it is a code fix bug)

        public static string RenderFooBar(this HtmlHelper helper)
        {
            // do something without helper
            return "footbar";
        }

[cybermaxs]

True, but sometimes it’s better to keep it coherent with common conventions. In asp.net MVC, we generally create extension methods on HtmlHelper for ‘everything that will generate Html’.

//csharp
     public static class LabelExtensions
     {
          public static string Label(this HtmlHelper helper, string target, string text)
          {
               return String.Format("<label for='{0}'>{1}</label>", target, text);

          }
     } 
//razor vew
 <%= Html.Label("firstName", "First Name:") %> 

But I think the general suggestion is more :: should it provide a fix that is useless and will break the code ?

[giggio]

@KristianWedberg It is not hard to find out, but as I said earlier, this is exactly the case where you suppress the analyzer directly in the source, that is what a suppression is for. 😉