Enable/Disable Endpoint should show duration

Both if it were disable and if it is still active. Seeing something like: durationMinutes: 180 makes for some simple math so the caller doesn’t have to worry about when something was enabled (regardless of timezone).

Duration Is probably a poor name. minutesActive might be clearer. It would keep counting up if it hasn’t been disabled.

Feel free to ignore this idea though if it distracts from the endpoint’s purpose.

_Originally posted by @checketts in https://github.com/codecentric/chaos-monkey-spring-boot/issues/246#issuecomment-890033899_

[checketts]

To fix the failing test, it looks like it works fine if you convert it to millis:

assertThat(disabledDto.getTimeActive().toMillis()).isPositive(); 

I not particularly opposed to the Duration in the ednpoint. More just annoyed with its toString() in general. 😉 So feel free to ignore my comment in that regard.

However, if you were curious, here is how you could change the DTO:

@Data
public class ChaosMonkeyDisabledDto {
  private final String status = "Chaos Monkey is disabled";
  private final ZonedDateTime disabledAt = ZonedDateTime.now();
  private final Duration timeActive;
  private Duration timeInactive;

  public ChaosMonkeyDisabledDto(ChaosMonkeyEnabledDto chaosMonkeyEnabledDto) {
    this.timeActive = chaosMonkeyEnabledDto.getTimeActive();
  }

  @JsonIgnore
  public Duration getTimeActive() {
    return timeActive;
  }

  @JsonProperty("timeActive")
  public String getTimeActiveMS() {
    return formatDuration(timeActive.toMillis());
  }

  public Duration getTimeInactive() {
    timeInactive = Duration.between(disabledAt, ZonedDateTime.now());
    return timeInactive;
  }

  @JsonProperty("timeInactive")
  public String getTimeInactiveMS() {
    return formatDuration(timeActive.toMillis());
  }

  private String formatDuration(long durationMs) {
    DecimalFormat df = new DecimalFormat();
    df.setMinimumFractionDigits(1);

    if(durationMs >  3_600_000) {
      return df.format(durationMs / 3_600_000.0) + " hours";
    } else if (durationMs > 60_000) {
      return df.format(durationMs / 60_000.0) + " minutes";
    } else {
      return df.format(durationMs / 1_000.0) + " seconds";
    }
  }


}

And the test:

  // DISABLE CHAOS MONKEY
  @SuppressWarnings({"rawtypes", "unchecked"})
  @Test
  void postToDisableChaosMonkey() {
    ZonedDateTime disabledAt = ZonedDateTime.now();
    ResponseEntity<Map> result = testRestTemplate.postForEntity(baseUrl + "/disable", null, Map.class);

    assertEquals(HttpStatus.OK, result.getStatusCode());
    assertThat(result.getBody()).containsEntry("status", "Chaos Monkey is disabled");
    assertThat(result.getBody()).containsKey("disabledAt");
    assertThat(result.getBody()).containsEntry("timeInactive", "0.0 seconds");
    assertThat(result.getBody()).containsEntry("timeActive", "0.0 seconds");
  }

[checketts]

I’m not a huge fan of the Duration.toString(). It never is very intuitive for me. A simple method to write out a decimal of total second/minutes/hours wouldn’t take much and would make it much easier to read.

if(durationMs >  3_600_000) {
  return fmtTo2Decimal(durationMs / 3_600_000.0) + " hours"
} else if () {
   return fmtTo2Decimal(durationMs / 60_000.0) + " minutes"
} else {
    return fmtTo2Decimal(durationMs / 1_000.0) + " seconds"
}