`v2` is not working, cannot find module 'asn1.js'

https://github.com/ansible-collections/community.hashi_vault/pull/108/checks?check_run_id=3105099310#step:7:10

Put up a PR to try to use v2, but it seems to be failing. This is on an ubuntu-latest runner, not in a container.

Error text:

internal/modules/cjs/loader.js:800
    throw err;
    ^

Error: Cannot find module 'asn1.js'
Require stack:
- /home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
    at Function.Module._load (internal/modules/cjs/loader.js:690:27)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at o (/home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js:6960:200)
    at /home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js:6960:391
    at Object.<anonymous> (/home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js:38030:27)
    at Object.108.../../config (/home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js:38601:4)
    at o (/home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js:6960:340)
    at /home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js:6960:391 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/_actions/codecov/codecov-action/v2/dist/index.js'
  ]
}

[thomasrockhu]

@briantist taking a look now, thanks

[briantist]

20,000+ files to upload used to take 1m10s~1m30s with @v1, and it’s taking 15s-20s with @v2

@briantist I love these numbers! For clarity, you are saying it’s faster for the uploader binary to scan for coverage files then the old bash one did?

@drazisil-codecov Yes that’s correct!

For comparison, check any of the four “Units” jobs in these CI runs:

codecov@v1: https://github.com/ansible-collections/community.hashi_vault/runs/3105213359?check_suite_focus=true codecov@v2: https://github.com/ansible-collections/community.hashi_vault/runs/3106559270?check_suite_focus=true

The I tests show improvement too but it’s harder to see. With just over 700 reports, the difference is something like 13s vs. 4s but there’s more variance, I suspect there’s a few seconds of overhead in the beginning either way? But yeah with a large number, the difference is very significant.

Edit: the number of files is much less than I thought, looks like 8,908, I was at first naively just looking at the rough number of output lines from the action, but it seems to list the files and then process the files, so each one gets at least 2 lines in the output. Even better news I guess since big improvements can be seen with a smaller number than expected.