[closebrackets] in comment, addon closes parens but not quotes

https://codemirror.net/demo/closebrackets.html

Repro:

1. add // to a line
2. type ( after it
3. type ' after it

Expected: Either they should both be completed with the closing pair (preferable), or neither of them should be.

Actual: A ) is automatically inserted, but a ' is not

[marijnh]

That heuristic seems to catch most cases—it seems the code was already doing all of that except for the check for a word char before the cursor. Attached patch adds this, replacing the string token heuristic. This will lead to suboptimal behavior when a string ends in a non-word character and is, for some reason, not closed by the automatically inserted matching quote from the opening quote, but it’s much simpler.

Does this work for you?

[marijnh]

Quote-closing in general does not work in contexts that don’t tokenize quoted strings, because it is impossible to generally decide whether a quote opens or closes a string. This is intentional—even with a bunch of heuristics (recognizing comment or nested string context, counting quotes, etc) this’d be very error-prone, and I don’t want to go there.