[Bug]: Argon2 Again

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: All
• Local OS: All
• Remote OS: All
• Remote Architecture: ARM64 (maybe for now)
• code-server --version: Latest

Steps to Reproduce

Prerequisite: Node 16 only

1. Install via Yarn
2. See Argon2 error

Expected

We are supposed to see a successful installation.

Actual

The bad old argon2 dependency error happens. We last saw this in #4422.

Logs

Logs can be found at this discussion: #5381

Screenshot/Video

At #5381

Does this issue happen in VS Code or GitHub Codespaces?

• I cannot reproduce this in VS Code.
• I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

I couldn’t dig properly, but I think node-rs adopted a new problem, perhaps? @yisibl would love to hear your insight on this!

My notes will be continued in comments later on. My first point is this:

This was supposed to be fixed in #4733, and so it was - I personally tested it via Node 14 on my 32-bit Raspbian install. This is back now, which makes it weird. I am going to need a bit of time on this - sorry, but I have a lot of things up next, like August 15, I have a job to do for that, as well as some other things.

@jsjoeio and @bpmct you are the people I know who have RPis set up. Can you install Node and check it? My install via nvm seems to be screwed up.

@yisibl you suggested @node-rs/argon2, have you noticed anything going haywire in the build logs? Maybe we could start on these things as I also try on my Zorin installation on my computer.

[ranisalt]

Yeah we have been reluctant to up the minimum glibc requirement since I think we had people on the product side using code-server on CentOS 7.

If you can confirm this data, I can try to build with an older distro, so it’s compatible. There is no hard requirement to support newer distros 😃

[code-asher]

IMO building from source sounds like it might be the best move for us at the moment.