Ctrl + Shift + {Left, Right, Home, End} is broken after a terminal is opened & closed

OS/Web Information

• Web Browser: Mozilla Firefox 88.0.1 (88.0.1+build1-0ubuntu0.20.04.2)
• Local OS: Ubuntu 20.04
• Remote OS: Ubuntu 20.04
• Remote Architecture: AMD64
• code-server --version: 3.10.2 387b12ef4ca404ffd39d84834e1f0776e9e3c005

Steps to Reproduce

1. With a freshly opened window, open a file with some text in it.
   • Try using Ctrl + Shift + Right, text should be selected at word boundaries.
2. Open a terminal, then close it using exit command.
3. Try using Ctrl + Shift + Right again.

Expected

Text should be selected at word boundaries.

Actual

No text is selected. Cursor doesn’t move at all.

Logs

• code-server-stderr.log
• code-server-stdout.log
• console-export-2021-5-28_23-16-18.txt
• code-server_Archive [21-05-28 23-14-41].zip (contains HAR file)
• The output of “Log (Window)”, with “Toggle Keyboard Shortcuts Troubleshooting” enabled: window.log

Notes

This issue can be reproduced in VS Code: No (Version: 1.57.0-insider, Commit: 1082913dd012e21cc5f35a06f15c480ca447f67f)

[code-asher]

I’m able to reproduce. Maybe it’s because of the Terminal: Resize Pane Right keybinding that’s bound to ctrl+shift+right in the terminal.

On Firefox when the terminal is closed there’s a bug where the close isn’t actually registered so maybe it still thinks the terminalFocus condition is true.

One workaround is to unbind it for now:

[
    {
        "key": "ctrl+shift+right",
        "command": "-workbench.action.terminal.resizePaneRight",
        "when": "terminalFocus && terminalProcessSupported"
    }
]

Possibly related: https://github.com/cdr/code-server/issues/1615

[peat-psuwit]

I’ve retested with an empty --user-data-dir; the problem still persists. So it can’t be extensions or custom keybindings.

But from the window log, this looks suspicious:

[2021-05-28 23:13:16.294] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowRight]
[2021-05-28 23:13:16.300] [window] [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.terminal.resizePaneRight, when: terminalFocus && terminalProcessSupported, source: built-in.

The terminal is not opened at that point.

On macOS, I think the fact that there’s some kind of Ctrl -> Cmd keybinding difference might cause the issue to not appear. You may have better luck reproducing it on Windows (if you can’t find a Linux/Ubuntu machine, that is).