playwright does not support FreeBSD as a platform.

OS/Web Information

• Web Browser: Firefox 95.0
• Local OS: FreeBSD 13.0
• Remote OS: macOS 12.0.1
• Remote Architecture: amd64
• code-server --version: N/A

Steps to Reproduce

1. cd code-server

2. Fix argon2 dependency to 0.28.2 to build.

3. yarn global add $PWD

Expected

It should build.

Actual

— stderr —

error /usr/home/khng/.config/yarn/global/node_modules/code-server/test/node_modules/playwright: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /usr/home/khng/.config/yarn/global/node_modules/code-server/test/node_modules/playwright
Output:
/usr/home/khng/.config/yarn/global/node_modules/code-server/test/node_modules/playwright/lib/utils/registry.js:233
            throw new Error('Unsupported platform: ' + process.platform);

Logs

Screenshot

Notes

This issue can be reproduced in VS Code: Yes/No

[khng300]

My guess for that problem was that node-argon2 was only trying to enforce C++17 on Linux only. Here is the fix for this part: ranisalt/node-argon2#332

Oh wow! You submitted a patch upstream - that is awesome! 🙌 I hope that resolves it.

That is only one of the problem, another one is actually mentioned above. I do want to know if it is safe to skip the test/ module as a temporary workarond.

EDIT: I noticed that yarn/npm --production should do the job

[khng300]

I am doing so to run the current snapshot from the main branch

In this case, it sounds similar to contributing. Assuming you followed the docs, let’s see if we can figure out what’s wrong.

so the first thing to attempt was to try 0.28.2 of node-argon2 which reverted the broken commit.

Ah, I see. Is this bug Linux specific? I’m surprised @code-asher isn’t running into this as he is on Linux.

Hmm…I really regret adding node-argon2. It’s causing a lot of trouble. We are looking into replacing it potentially here.

My guess for that problem was that node-argon2 was only trying to enforce C++17 on Linux only. Here is the fix for this part: https://github.com/ranisalt/node-argon2/pull/332