Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

convert-commonjs-to-esm doesn't work

See original GitHub issue

Issue Description

I enabled convert-commonjs-to-esm/require and convert-commonjs-to-esm/exports here: https://github.com/EvgenyOrekhov/eslint-config-hardcore/commit/90dc0972dc57e2ce5a3ac5183ec75d3b5f98bc22.

Now I expect it to complain about require() calls in test.js, but it doesn’t.

What did I do wrong?

Issue Analytics

State:
Created 2 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

EvgenyOrekhovcommented, Apr 26, 2021

It works now, thank you!

0reactions

coderaisercommented, Apr 26, 2021

Looks like it is related with configuration of convert-commonjs-to-esm, the whole rule is disabled by default with:

{
    "rules": {
        "convert-commonjs-to-esm": "off"
    }
}

And when you partially enable it with:

{
    "rules": {
        "convert-commonjs-to-esm": "off",
        "convert-commonjs-to-esm/require": "on",
        "convert-commonjs-to-esm/exports": "on"
    }
}

It’s do not get loaded, so one of solutions could be to enable the whole rule, and then disable parts you don’t need. Anyways it looks useful, worth fixing and landed in @putout/engine-loader v4.3.0 🎉 .

Is it works for you 😃?