convert-commonjs-to-esm doesn't work

I enabled convert-commonjs-to-esm/require and convert-commonjs-to-esm/exports here: https://github.com/EvgenyOrekhov/eslint-config-hardcore/commit/90dc0972dc57e2ce5a3ac5183ec75d3b5f98bc22.

Now I expect it to complain about require() calls in test.js, but it doesn’t.

What did I do wrong?

[EvgenyOrekhov]

It works now, thank you!

[coderaiser]

Looks like it is related with configuration of convert-commonjs-to-esm, the whole rule is disabled by default with:

{
    "rules": {
        "convert-commonjs-to-esm": "off"
    }
}

And when you partially enable it with:

{
    "rules": {
        "convert-commonjs-to-esm": "off",
        "convert-commonjs-to-esm/require": "on",
        "convert-commonjs-to-esm/exports": "on"
    }
}

It’s do not get loaded, so one of solutions could be to enable the whole rule, and then disable parts you don’t need. Anyways it looks useful, worth fixing and landed in @putout/engine-loader v4.3.0 🎉 .

Is it works for you 😃?