Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

@codemirror v0.18 in @codesandbox/sandpack-react breaks when targeted for es5

See original GitHub issue

Issue Description

Error

With @codemirror v0.18.0 builds break, which is being used from react-smooshpack-1.0.0-beta-0. Since, the @codemirror/autocomplete uses Nullish Coalescing. And it is not transpiled when published to npm.

I am not sure, if codemirror should handle this or the end user. But most of the build tools, don’t transpile their dependencies. And so, builds break when we transplie projects and not target es6 at the end.

new RegExp(`${addStart ? "^" : ""}(?:${source})${addEnd ? "$" : ""}`, expr.flags ?? (expr.ignoreCase ? "i" : ""));

Issue Analytics

State:
Created 2 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

alexnmcommented, Mar 14, 2021

I mean fixing to 0.18.0, not ^0.18.0. v0.17 has its issues as well 😛 it’s not the first time the library broke something in sandpack

0reactions

alexnmcommented, Mar 15, 2021

appears to be fixed in 0.18.2. I will probably block the dependencies for codemirror in the future, but for now, it should work with removing yarn.lock and reinstalling our package to v0.0.1