tapToDismiss ignored when onclick is set

Hello,

I’m trying to display a toast with the property tapToDismiss set to false

toastr.info('title', 'message', {
tapToDismiss: false, 
closeButton: true, 
timeOut: 0, 
extendedTimeOut: 0, 
});

This works well but if I add a onclick handler, the toast closes when I click it.

toastr.info('title', 'message', {
tapToDismiss: false, 
closeButton: true, 
timeOut: 0, 
extendedTimeOut: 0, 
onclick: function(){
    alert('click');
}
});

Currently, I’ve found a workaround by adding the click handler on the elem returned by the info method but I think there is a little bug here…

var toast = toastr.info('title', 'message', {
tapToDismiss: false, 
closeButton: true, 
timeOut: 0, 
extendedTimeOut: 0, 
});
toast.on('click', function(){
    alert('click');
});

Thanks

[RiCKe]

For the moment, I use the workaround shown in my third exemple. But i think this bug comes from line 297 in toastr.js

if (options.onclick) {
    $toastElement.click(function () {
        options.onclick();
        hideToast();
    });
}

Just add a check of tapToDismiss property before calling hideToast and it will do the trick

if (options.onclick) {
    $toastElement.click(function () {
        options.onclick();
        if(options.tapToDismiss){
            hideToast();
        }
    });
}

[raquelrocha]

I’m having this problem again, and i’ve checked toastr.js and somehow the change made here no longer exists:

if (options.onclick) {
   $toastElement.click(function (event) {
           options.onclick(event);
           hideToast();
    });
}

If it is meant to be this way, then please guide me to a workaround to this behavior.