question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Modal when opened changes the url

See original GitHub issue

Issue

Description

Whenever a modal window is opened, the url gets appended with #something. In case of popup this dosen’t make sense.

Screenshot

screen shot 2018-10-31 at 9 26 35 am screen shot 2018-10-31 at 9 26 06 pm

Steps to Reproduce

  1. Click on Cookies Policy
  2. Observe the url

Direct Requirements

  • Do not update the url
  • Please apply same fix to Privacy Policy, Terms and Condition and Cookie Policy in the footer

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:13 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
reactiongearscommented, Nov 2, 2018

The policy in my opinion should have a direct link URL. So the URL should change when visiting any of the policy pages. You will need these URLs when integrating with things like Google or Facebook tracking.

2reactions
nero2009commented, Oct 31, 2018

Oh my bad, I didn’t know there was a tertiary button that will be a better fit. cook

Read more comments on GitHub >

github_iconTop Results From Across the Web

Open modal and then change the url without redirecting
I'm trying to open a modal and change the url but stay on the same page. So it should just open a modal...
Read more >
Any way to change URL when modal is open? #250 - GitHub
You might be able to use the browser's window.history.pushState API within an event handler, possibly the 'modal:before-block' event.
Read more >
How to Update / Change URL when Popup Modal Loads?
I'm looking for a way to have a popup modal with a form, and whent he popup loads, ...
Read more >
How to change a URL when I open a modal with NextJS?
When you open a card -- the URL changes, but the state in the background layout remains the same. See the video example...
Read more >
Got Url Changes When Modal Dialog Open But I Need To ...
Got Url Changes When Modal Dialog Open But I Need To change Original url When I Close Modal using(jquery.history.js).
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found