Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

process.env

See original GitHub issue

Issue

Description

Using process.env is not great as the used env variables seem to be not declared anywhere. We should use cross-env for testing purposes and use some config for setting them instead of using process.env.

Issue Analytics

State:
Created 5 years ago
Comments:7 (1 by maintainers)

Top GitHub Comments

3reactions

charlesjliucommented, Oct 4, 2018

I don’t think we should have a .env committed into the repo.

https://www.npmjs.com/package/dotenv#should-i-commit-my-env-file

Is there a reason why those links are set using environment variables (slack etc.)? I don’t think those should be set by the environment.

If anything, you could set default values if the environment variables aren’t detected. We can have a sample .env file that developers can use to write their own and include instructions in the repo. But environment variables should be for things like… the CODING_COACH_API url, or whatever client API keys we’re using (like the Google Analytics example).

Just my two cents! 🤷‍♂️

0reactions

DanielRufcommented, Oct 4, 2018

Exactly. dot-env are normally meant for credentials and user specific settings.