A bug while renaming variables
See original GitHub issueHello, actually I have to say that Recaf is a very nice tool that I found. Both GUI and background stuff are cool. But I found a bug while renaming variable names. I wish I could send the jar file but I dont own it. Let me explain the bug.
Lets say there are 2 classes named A and B, and B extends A. When I try to rename a variable in A, it renames all the variables matching in A(and maybe some other classes), but it doesn’t rename that variable on B class. And this causes to crash the program(not Recaf).
The error when this bug happens: java.lang.NoSuchFieldError: variableName
Actually I could challange with this by renaming the variables back to original ones, but it took long and i think this bug is an unintended thing when renaming.
Thanks for replying my issues.
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (4 by maintainers)
Top GitHub Comments
Actually I was saying that if I rename a variable on a super class, it has to be renamed on all child and child’s child … and so on. You also fixed this on v2.7.0.
My second thing in that post is, if I search a super class’s variable by right clicking it and selecting “Search References”, it auto fills “Owner” section by this super class’s name, and causes me to can’t find references on child classes, because child classes gets this variable by its own name (
GETFIELD Child.parentsVariable
), so i clear the “Owner” section but then i get lots and lots of search result because of obfuscation has renamed variables like a,b,c…My advice is, add an option button or box while searching variables, something like ‘Also search on child classes’
Oh that’s a good point for searching