Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ESC key should close search dialogue

See original GitHub issue

When making a search, we should a dropdown with autocomplete results

If that dropdown is open and someone clicks outside of that box, we clear the search and close the modal

If someone presses ESC while that dropdown is open, we should similarly cleare the search and close the modal

we can use the document onClick functionality as an example of how to implement in Nav.js

addDocumentOnClick, removeDocumentOnClick, and handleOnDocumentClick

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:26 (20 by maintainers)

github_iconTop GitHub Comments

jatin-ratheecommented, Oct 28, 2020

@colbyfayock opened new issue #86

GuilleAngulocommented, Oct 27, 2020

hey @jatin-rathee have you tried using your IP instead of localhost? Also you need to remove last trailing slash, to allow graphql calls be properly made (it is added inside the code /grapqhl to the variable).


I hope that solves it

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Close a Modal / Dialog Box Using the ESC Key?
This script closes modals one by one according to opening order with escape key. And also you don't need to define any modal...
Read more >
Dialogue Box supposed to be closed by default with the [ESC ...
Closing the dialogue box using a shortcut should only be avalible if the message is not important: Not seeing the whole message will...
Read more >
Activate escape button to close Search dialog, like many other ...
Activate <ESC> escape button to close Search dialog, like many other Windows programs. Having to manually mouse click the 'OK' button on the ......
Read more >
Conditional closing of a dialog using ESC key - MSDN
I have a dialog which is an editor and I allow the user to close it down using the ESC key. To do...
Read more >
[feature request] dialogs should close after pressing "esc" key
If I open the select and then press ESC to close the select, I end up closing the dialog as well. Ideally there...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found