BooleanField is_true and is_false methods

Proposal

Add methods to BooleanField so that we can create expressions like MyModel.my_field.is_true() and MyModel.my_field.is_false() instead of MyModel.my_field == True and MyModel.my_field == False.

Rationale

I’m using flake8, with a selected list of pycodestyle error codes, and using MyModel.my_field == True triggers the E712 error, comparison to True should be ‘if cond is True:’ or ‘if cond:’.

That would be consistent with the is_null method, which is used instead of a “MyModel.my_field == None”.

Reference implementation

peewee.BooleanField.is_true = lambda self: peewee.Expression(self, peewee.OP.EQ, True)
peewee.BooleanField.is_false = lambda self: peewee.Expression(self, peewee.OP.EQ, False)

[coleifer]

I appreciate you taking the time to submit this issue. Unfortunately, peewee does quite a few things that many linters find egregious. I don’t use linters myself, so it doesn’t bother me and personally I’m not interested in adding code simply to satisfy flake8. Thanks for providing a reference implementation, anyone who is interested can use your code or subclass BooleanField and add the suggested methods.

[coleifer]

Is there any example with some different approach to avoid Something.my_field == True while doing the same?

You’ve shared a nice one.