Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

UNION query is not using parenthesis

See original GitHub issue

Hello, I’m doing the following query (on mysql):

    s1 = SiteLog.select(SiteLog.time).order_by(SiteLog.time.desc())
    s2 = SubLog.select(SubLog.time).order_by(SubLog.time.desc())
    final = (s1 | s2)

and the sql result is

SELECT `t1`.`time` FROM `site_log` AS `t1` ORDER BY `t1`.`time` DESC UNION SELECT `t2`.`time` FROM `sub_log` AS `t2` ORDER BY `t2`.`time` DESC

This lacks the parenthesis around each query so the mysql server ends up throwing a syntax error:

peewee.ProgrammingError: (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'UNION SELECT `t2`.`time` FROM `sub_log` AS `t2` ORDER BY `t2`.`time` DESC' at line 1")

What am I doing wrong?

Issue Analytics

State:
Created 5 years ago
Comments:9 (6 by maintainers)

Top GitHub Comments

1reaction

coleifercommented, Sep 17, 2019

See also #2014 – mysql and mariadb are a pile of inconsistency when it comes to parsing sql.

Bug for MySQL (opened in 2007) was finally fixed for MySQL 8.0 release: https://bugs.mysql.com/bug.php?id=25734

MariaDB thought they fixed it for 10.4: https://jira.mariadb.org/browse/MDEV-11953

But they missed some scenarios, including using compound select queries inside an IN expression (e.g.). I’ve opened a ticket, so we’ll see what happens: https://jira.mariadb.org/browse/MDEV-20606

0reactions

Polsakercommented, Feb 12, 2019

Thanks! This all was pretty quick!