Add `.finite()` for numbers? Or require numbers to be finite by default?

Usually, when I want a number, I want it to be finite.

I’d like to be able to say something like z.number().finite() to represent numbers that can’t be Infinity or -Infinity.

Or, even better in my opinion (but a breaking change), I’d prefer that the default number implementation disallow non-finite values, so that z.number().parse(Infinity) throws an error. I think it’d be consistent with rejecting Number.NaN, since Infinity is a number-like thing in javascript that’s not really a number, and NaN is already disallowed.

Would you accept a PR to make either of these changes?

[kmbt]

I understand your point and do agree that excluding NaN from z.number() and requiring it to be specified explicitly by union can actually benefit most real-life use-cases and also help spot math errors.

But then, by the same rationale, why include Infinity which can be a result of division by zero? I can’t remember the last time I wanted to get Infinity passed anywhere either. Perhaps it should be removed then - for consistency.

I also think that it would be good idea to put those values in the docs so that it would be made clear which of the possible values for number type are accepted and which are not.

[FlorianWendelborn]

@stale bump