question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Batch repo enhancements

See original GitHub issue

Let me please propose batch of changes to the DX, so it’d be easier for others to contribute. Please let me know what you would approve, so I’d know what to help you with 😃

Todo (Not started yet)

  • add automated releases generation and make commits messages more strict
    • as a user of this library, it was a bit time consuming to browse commits to realize what changed between beta versions

Completed

  • use typescript-eslint instead of tslint
    • it’s been almost 2 years since the standard in TS linting is ESLint, more info
  • add .log files to .gitignore
    • for example, there’s already a mistakenly uploaded yarn-error.log
  • bump prettier & use community defaults
    • let’s use the defaults, so it’s more likely to please higher % of contributors
  • add .npmignore to exclude unrelated files from the deployed package
    • improve the files + exclude instead
  • remove empty dependencies object from package.json
  • add husky to add git hooks
    • it’s important to automatically prevent issues like in #218 from happening, when there are bunch of unrelated formatting changes
      • at least automatic code formatting should be in place
  • add official funding references of your GitHub sponsors link to the package.json

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:3
  • Comments:12 (6 by maintainers)

github_iconTop GitHub Comments

3reactions
jameschensmithcommented, Dec 4, 2020

@o-alexandrov, are you still working on this? I’d like to contribute on this if possible. @colinhacks, I could start getting separate PRs up for each of the points listed in the initial message. Let me know your thoughts when you get a chance, and I’ll get the first PR pushed right away 😊

2reactions
colinhackscommented, Dec 8, 2020

@o-alexandrov I removed tslint entirely since I never actually used yarn lint and it wasn’t integrated into the build process in any way. So perhaps the first item should be “Add eslint-typescript”.

I checked off “funding”.

I also checked off “prettier” having just merged @jameschensmith’s #260

I also checked off “exclude”. It’s now using includes (not files) and excludes to prevent unused files from getting deployed. I just merged that change last night.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Introducing Batch Changes - Sourcegraph
Learn how to automate and track large-scale code changes across all of your repositories and code hosts with Sourcegraph Batch Changes.
Read more >
gbup-group/IEBN: The official implementation of paper ...
This repository is the implementation of "Instance Enhancement Batch Normalization: an Adaptive Regulator of Batch Noise" [paper] on CIFAR-100 dataset.
Read more >
Spring Batch 5.0 Goes GA!
Spring Batch 5 is the culmination of two years of work, including dozens of improvements, features, and bug fixes by more than 50 ......
Read more >
Enhancement spot for MSC1N,MSC2N, MSC3N
Hi, There is a requirement to include the GOS for the batch master transaction MSC1N, MSC2N and MSC3N. Object type 'BUS1001002' and ...
Read more >
Batch Processing Large Data Sets with Spring Boot and ...
The item is read by ItemReader and passed onto ItemProcessor, then it is written out by ItemWriter once the item is ready. The...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found