userModel is not extended correctly

When extending the user model, nested arrays are not concatenated their positions are overwritten.

ie:

var userModelConfig = {whitelist: ['1','2','3','4','5','6']}
var userModel = {whitelist: ['a','b','c']}

$.extend(true, {}, userModel, userModelConfig)
//returns
{"whitelist":["1","2","3","4","5","6"]}

and
$.extend(true, {}, userModelConfig, userModel)
"{"whitelist":["a","b","c","4","5","6"]}"

As you can see the index position of the array is overwritten rather then extend or merged.

A potential solution would be to transform the arrays into objects, extend them and transform them back.

I was going to try to fix it and submit a pull request, but i dont have the time tonight so i wanted to get this to you, maybe you have a quicker solution.

[colinskow]

OK, now I understand exactly what you are saying. Currently if you want to change the whitelist, you have to repeat it:

whitelist: [
      'name',
      'username',
      'email',
      'password',
      'confirmPassword',
      ...
    ],

I’ll work on this for the next version of SuperLogin, but don’t know when I’ll get to it. If you can do I pull request with a passing test in user.spec.js then I would be happy to merge it.

[raymatos]

So what im trying to say is the node extend is basically a clone to jquery extend. And extend will not merge 2 arrays.

So for example, if you were to add this to the config file

userModel: {
    whitelist: [
      'interests',
      'unit',
      'age',
      'subscribe',
      'zipcode'
    ]
  }

You would get an error saying the username, password, and confirmPassword is required. This is because userModel = extend(true, userModel, config.getItem('userModel')); would return the whitelist array like this

whitelist: [
      'interests',
      'unit',
      'age',
      'subscribe',
      'zipcode'
    ]

This is because extend will overwrite the array rather then merge them. But what you really want is a unique merge.

Hope that makes more sense.