Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Overriding the Html5 tech causes error on videos without plugins

See original GitHub issue

Issue Description

Description

Can’t play video without wavesurfer set up in plugins.

Steps to reproduce

In the video example, change var player to:

var player = videojs('myVideo', {
    controls: true,
    autoplay: false,
    fluid: false,
    loop: false,
    width: 600,
    height: 300,
    sources: [{ src: 'media/example.mp4' }]

(Remove plugins, add sources, change autoplay)

Results

Expected

Video to play normally without wavesurfer plugins set up. (I want to have multiple videos on a page, some with wavesurfer, some without)

Actual

Unresponsive controls on video(s) without wavesurfer set up.

Error output

Firefox: _this.activePlayer.activeWavesurferPlugin is undefined Chrome:

Uncaught TypeError: Cannot read property 'on' of undefined
    at new WavesurferTech (videojs.wavesurfer.js:88)
    at e.loadTech_ (video.min.js:6)
    at e.src_ (video.min.js:6)
    at video.min.js:6
    at $t (video.min.js:1)
    at $t (video.min.js:1)
    at e.<anonymous> (video.min.js:1)
    at r (video.min.js:2)

Additional Information

The problem seems to be with overriding the Html5 tech. Changing line 1082 in videojs.wavesurfer.js from _video2.default.registerTech('Html5', _tech2.default); to _video2.default.registerTech('Wavesurfer', _tech2.default); appears to fix this functionality, although videojs.wavesurfer.css is still in effect, which causes the time remaining and fullscreen icon to overlap.

versions

Using video.js 6.5.1 and wavesurfer.js 2.0.0-beta02 with videojs-wavesurfer 2.0.3 in Firefox Developer Edition 58 and Google Chrome 62 on Windows 10

Issue Analytics

State:
Created 5 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

everruler12-secondarycommented, Dec 11, 2017

Sounds good, can you make a pull request?

Pull request submitted

0reactions

thijstriemstracommented, Dec 8, 2017

Perhaps this could be fixed by including this.player.addClass(‘videojs-wavesurfer’); (like here) if the plugin is initialized, and then updating the css file with this class?

Sounds good, can you make a pull request?