Proper annotations

Right now mypy, pyright and other static type analyzers are screaming from annotations like this: id: Integer(primary_key=True)

mypy error:

lmat/db/models.py:33: error: Invalid type comment or annotation  [valid-type]
lmat/db/models.py:33: note: Suggestion: use Integer[...] instead of Integer(...)

pyright error:

Expected class type but received "Integer" Pyright (reportGeneralTypeIssues)

Why id = Integer(primary_key=True) syntax is not used (like in orm)? I guess it is because of the way you extract annotations, do you consider changing the approach? I would like to use this library in one project, but it is unusable in this state (I cannot just put # type: ignore[valid-type] on every line in models)

Can help with this when I have some spare time, unfortunately I am forced to go back to orm.

[zdytch]

Suffering from this right now. In VSCode I have Pylance type checking on. It is based on Pyright and Mypy.

So when I don’t use annotation, like this: size = ormar.Integer(minimum=0, default=0) no screaming

But, when I add annotation: size: int = ormar.Integer(minimum=0, default=0) i get the error:

Expression of type "BaseField" cannot be assigned to declared type "int"
  "BaseField" is incompatible with "int" 

Adding # type: ignore to the file top of the file or to separate line hides the error

[collerek]

Sorry for late answer, will try to tackle this one in the nearest future. Any help welcomed! 😊