QuerySet operations returns Sequence instead of List

Describe the bug The QuerySet operations return value is Sequence[“Model”] even though on the DocString it is stated as List[“Model”] It is causing for lint errors as mismatch types when trying to retrieve the returned object as List.

for example:

rows: List[User] = await User.objects.all()

Will cause a lint error on mismatch type.

Looking into Ormar source code it seems the first time where this is starting to get confused is at: ormar.models.mixins.merge_mixin.py ==> merge_instances_list class method

from source-code:

@classmethod
    def merge_instances_list(cls, result_rows: Sequence["Model"]) -> Sequence["Model"]:
        """
        Merges a list of models into list of unique models.

        Models can duplicate during joins when parent model has multiple child rows,
        in the end all parent (main) models should be unique.

        :param result_rows: list of already initialized Models with child models
        populated, each instance is one row in db and some models can duplicate
        :type result_rows: List["Model"]
        :return: list of merged models where each main model is unique
        :rtype: List["Model"]
        """

as you can see rtype on DocString is List[“Model”] while the annotated return type is Sequence[“Model”].

If there is any specific reason and I can assist with fixing - I will be very happy to do so! The package is very helpful and it is much appreciated!

[collerek]

Ok, since this one should be fixed and we still have #112 I will close this one, we can discuss either in 112 or #124

[collerek]

Yeah, I merged the m2m branch to release it and now we can peacefully work on this one and rest of the issues 😃 Thanks for your work, will check the PR and proposed fix! 😃