Saving related model broke in latest release

I have a test that started failing after I updated to the latest 0.7.0 release.

c = await domain.Category(name="Foo", code=123).save()
ws = await domain.Workshop(topic="Topic 1", category=c).save()

assert ws.id == 1
assert ws.topic == "Topic 1"
assert ws.category.name == "Foo"

Simple test, and the error is

E       AssertionError: assert None == 'Foo'
E         +None
E         -'Foo'

I can see that the category gets saved and is also saved in the database for the workshop, but it’s not updated in the model correctly. In the ws.category I see only the id column, and saved = False.

[collerek]

OK,

I wanted to make sure that pre-save signal receive the model with populated defaults and overdid it, sorry 😃

Should be fixed in 0.7.1.

Btw. When you want pytest fixture to run only once for whole module (like db creation) you cen set scope=module option in fixture decorator

@pytest.fixture(autouse=True, scope="module")
def create_test_database():
    engine = create_engine(DATABASE_URL)
    metadata.create_all(engine)
    yield
    metadata.drop_all(engine)

That way you don’t have to pass the fixture around to test functions.

Also now you run against sqlite but if you intend to run against mysql or postgress you need to actually explicitly connect in test - best as a context manager with nomen omen with 😉

@pytest.mark.asyncio
async def test_model_relationship():
    async with db:
        async with db.transaction(force_rollback=True):
            # rest of the test

It does not affect sqlite buf fixes test for other backends.

[collerek]

This passes for me:

@pytest.mark.asyncio
async def test_model_relationship():
    async with db:
        async with db.transaction(force_rollback=True):
            cat = await Category(name="Foo", code=123).save()
            ws = await Workshop(topic="Topic 1", category=cat).save()

            assert ws.id == 1
            assert ws.topic == "Topic 1"
            assert ws.category.name == "Foo"

            ws.topic = 'Topic 2'
            await ws.update()

            assert ws.id == 1
            assert ws.topic == "Topic 2"
            assert ws.category.name == "Foo"

So let me know if you still have the same problem.