'str' object has no attribute 'toordinal'

Describe the bug Hi!

After the latest update (0.10.24), it looks like querying for dates, using strings, is no longer working.

• My field is of type ormar.Date(nullable=True).
• Calling await MyModel.objects.get(field=value) fails when the value is '2022-01-20'
• Calling await MyModel.objects.get(field=parse_date(value)) works when the value is ^

Querying with the plain string value worked before (on 10.23).

Stack trace

../../.virtualenvs/project/lib/python3.10/site-packages/ormar/queryset/queryset.py:948: in get
    return await self.filter(*args, **kwargs).get()
../../.virtualenvs/project/lib/python3.10/site-packages/ormar/queryset/queryset.py:968: in get
    rows = await self.database.fetch_all(expr)
../../.virtualenvs/project/lib/python3.10/site-packages/databases/core.py:149: in fetch_all
    return await connection.fetch_all(query, values)
../../.virtualenvs/project/lib/python3.10/site-packages/databases/core.py:271: in fetch_all
    return await self._connection.fetch_all(built_query)
../../.virtualenvs/project/lib/python3.10/site-packages/databases/backends/postgres.py:174: in fetch_all
    rows = await self._connection.fetch(query_str, *args)
../../.virtualenvs/project/lib/python3.10/site-packages/asyncpg/connection.py:601: in fetch
    return await self._execute(
../../.virtualenvs/project/lib/python3.10/site-packages/asyncpg/connection.py:1639: in _execute
    result, _ = await self.__execute(
../../.virtualenvs/project/lib/python3.10/site-packages/asyncpg/connection.py:1664: in __execute
    return await self._do_execute(
../../.virtualenvs/project/lib/python3.10/site-packages/asyncpg/connection.py:1711: in _do_execute
    result = await executor(stmt, None)
asyncpg/protocol/protocol.pyx:183: in bind_execute
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   asyncpg.exceptions.DataError: invalid input for query argument $2: '2022-01-20' ('str' object has no attribute 'toordinal')

---

Let me know if you want me to try and create a reproducible example. I thought I would open the issue first, in case you immediately knew what might have changed.

Thanks for maintaining the package! 👏

[sondrelg]

It looks like aiopg handled the date casting like before. I’ll use this for a bit and report back, but looks good 👍

[collerek]

Yes, unfortunately it would break complex types, it was also using not really safe literal binds docs. Although I was re-parsing it to sqlalchemy text clause you couldn’t inject SQL it was still against best practices, and was only working for simple types (didn’t work for example with dates, I had to dump them to isoformat string, which in turn was breaking the timezones 😱 )

As a quick workaround can you try the other driver from databases? Maybe it’s more permissive (aiopg instead of asyncpg)? Or maybe that needs to be fixed in databases itself, will check that.