Match-maker: RoomListingData returns wrong number of clients after client reconnect

After implementing client reconnect, I noticed that the connections count in the Colyseus monitor is wrong after a client successfully reconnected to a room. For each successful reconnect, the connection count is decremented by one. Reconnecting multiple times can result in negative connection counts. Inspecting the room yields the correct connection count.

Digging through the code showed me that the endpoint simply displays the match-maker query. So I suspect a bug in the match.-maker itself.

Steps to Reproduce

1. Connect to a room and go to the Colyseus Monitor: “1 Connection”
2. Client loses connection and successfully reconnects using client.reconnect()
3. Go to Colyseus Monitor again: “0 Connections” but the room still exists
4. Click on the room: “1 Connection” (which is correct)

Context

Trying to implement client reconnect with the standard procedure as stated in the docs.

Your Environment

• Colyseus Version: 0.14.20
• Colyseus.js Version: 0.14.13
• Colyseus Monitor Version: 0.14.20
• Node.js Version: 14.15.3
• Operating System and version: Linux Mint 20.2 (Kernel 5.8.0)

[CookedApps]

@lpsandaruwan Interesting. We do it like in your first example. That explains it.

[endel]

Thanks for looking into this @lpsandaruwan

Maybe this behaviour happens on the same scenario as https://github.com/colyseus/colyseus/issues/348#issuecomment-913933140